elementary / files

File browser designed for elementary OS
https://elementary.io
GNU General Public License v3.0
323 stars 75 forks source link

(Mixed mode) clicking on a file should open its details in the next column #1601

Open hanaral opened 3 years ago

hanaral commented 3 years ago

Problem

When in column view, clicking a folder lists its contents in the next column over. However, doing the same to a file just opens the file rather than listing a preview said files contents.

Proposal

The next column over should display the preview of the file when it is clicked, optimally with images and videos using the same fast preview image generation as the current previews used in icons. I know this idea has been tossed around and that there is a branch for a sidebar, but that defeats the purpose almost entirely. The point of the macOS column view is to list or preview an items contents for both files and directories in the same way, not to have one of them use the column system and the other to have a permenant section of the UI filled up with something better of as a seperate window.

Prior Art

Screenshot from 2021-02-25 14-51-54 This also illustrates the difference between what a breif preview means and what a properties menu looks like

cassidyjames commented 3 years ago

Yes, with mixed mode it makes sense to put file properties into a column/right sidebar somehow as mentioned here:

  • Single-clicking a file shows Properties. Since Files is a file manager and not an app launcher, it might make sense that the "final destination" when navigating to a file is to show the details about that file, not necessarily to open a different app.

  • Add an "Open in Foo" (default app) suggested action button to Properties, to make a single-click flow still work well for opening files while making it more explicit this is opening a new app.

  • Properties as a right-side pane. This could be in a follow-up branch to keep things simpler. But putting properties in a side pane is consistent with what we've done in other apps (see: Music), and feels less invasive than opening a dialog on top of the current view. It especially will feel nice in the Column view, but should work well everywhere. It could also sort of act as a "preview" mode if we get higher-res thumbnails/previews in the properties… but that's probably getting ahead of ourselves.

and here:

I have been trying this for a bit and really like where it's going UX-wise. I think it will feel even better if we get a Properties sidebar on file select, as then something still happens when clicking files. Of course something to figure out there will be if the sidebar causes a reflow, or overlays, or what. But I do think that can be addressed in a future branch.

We still need to sort out how this works in the various views, i.e. if it overlays or reflows or expands the window, or what.

hanaral commented 3 years ago

I should probably reiterate that it makes more logical sense and takes up significantly less UI room to add the preview of the file directly in to the next column, even if that sort of implementation would require more effort than just adding a sidebar.

jeremypw commented 3 years ago

The view widget (Slot) does have the functionality to show extra widgets in addition to or instead of the directory view (AbstractDirectoryView), at the moment used for e.g. Trash action bar. Show showing a properties widget in a column in ColumnView should therefore not be a problem. The other views would have to be modified somewhat to be able to show an extra widget to the side rather than at the top or bottom but it should be possible.

jeremypw commented 3 years ago

Need to get a good design done before leaping into coding though, of course.

hanaral commented 3 years ago

I've been mocking up what it could look like for a couple of hrs, it's not that great but I think the arrows and symbolic ticks fit well and can be coloured easily; Files better column view mockup