search

elementary / files

File browser designed for elementary OS
https://elementary.io
GNU General Public License v3.0
330 stars 78 forks source link

Mounted drives unmount when system is restarted, affects bookmarks #1795

Open abodedis opened 3 years ago

abodedis commented 3 years ago

What Happened

Mounted drives unmount when system is restarted, affecting Bookmarks.

Expected Behavior

a) If a user mounts a drive, the drive should stay mounted until the user hits the Eject key. b) If a user clicks a bookmark to a drive not currently mounted, the drive should be auto-mounted and the folder should be attempted to be located before displaying a "Folder not found" error.

Steps to Reproduce

  1. From the list of drives found under "Storage", click an unmounted drive to view its contents.
    This applies to a secondary hard drive installed in the system, or a network share, or any storage device that a user would reasonably expect to stay mounted.

  2. Create a bookmark to a folder in the drive selected from Step 1.

  3. Restart the computer.

  4. When returning to Files, the drive selected from Step 1 will no longer be mounted. Don't click on the drive to remount it.

  5. Without remounting the drive, click on the Bookmark. A "Folder Not Found" error will be displayed, which is unexpected behavior because the folder exists and it is only because the drive was not remounted.

Logs

Platform Information

OS: elementary OS 6 Odin x86_64 Kernel: 5.11.0-27-generic Packages: 1699 (dpkg), 20 (flatpak) Shell: bash 5.0.17 Resolution: 3840x2160 DE: Pantheon WM: Mutter(Gala) Theme: io.elementary.stylesheet.blueberry [GTK3] Icons: elementary [GTK3] Terminal: io.elementary.t CPU: Intel Xeon W3680 (12) @ 3.326GHz GPU: NVIDIA GeForce GT 1030 Memory: 1370MiB / 24047MiB

jeremypw commented 3 years ago

It is normal that only mounts that are defined in /etc/fstab are remounted after a reboot.

You are correct that if there is a bookmark to a folder at a mountable location (including a network location) then clicking it should attempt to mount it if possible. I can confirm this does not happen for locations on unmounted local partitions. I am pretty sure they used to be automounted so it looks like a regression.

jeremypw commented 3 years ago

I have checked and remote locations (with a uri protocol other than file://) do automount if they are not already mounted. However bookmarks to local unmounted partitions do have a file:// protocol and a path like /media/<USER>/<UUID>/<path> so there is no obvious way for Files to known that they are on a mountable location. It may be possible for Files to parse the path into something mountable I suppose, but the best solution at the moment is to add the drives/volumes that you want to bookmark to the `/etc/fstab/ list or just mount them manually before using the bookmark.