search

elementary / files

File browser designed for elementary OS
https://elementary.io
GNU General Public License v3.0
330 stars 77 forks source link

Do not activate "find" with space character #2452

Closed jeremypw closed 3 months ago

jeremypw commented 3 months ago

Fixes #2451

janxkoci commented 3 months ago

The bug does not actually activate the find function - the cursor just appears where find/path/breadcrumbs usually appear, but typing is not doing anything. It is basically just an empty text field that does nothing useful.

Using Ctrl+F to activate search, or Ctrl+L to focus path both work as expected, but space bar doesn't do any of that, it's a dead key.

jeremypw commented 3 months ago

The search function also seems broken on Wayland and after making preparations for Gtk4 but that is a separate issue. I am working on a fix for that.

janxkoci commented 2 months ago

I also noticed dragging the window by pathbar (breadcrumbs) no longer works and I have to drag by the remaining (little) parts of the headerbar. Not sure if it's related, but I think it broke around the same time.

And sorry for late comment, I had some time off.

jeremypw commented 2 months ago

@janxkoci Confirmed. Will need another issue report. Note you can drag the whole window by holding down the "Super" key before dragging (on OS8). Normal dragging on the other controls in the header also works, but clicking on the pathbar is now grabbing focus. Not sure why.

janxkoci commented 2 months ago

I may report it after tomorrow's deadline, now I'm too busy, just taking a break for dinner. I know I can drag on the buttons too, like in all GTK apps (I missed that on macOS), but the path bar is still the largest widget, so would be cool to have that back.

PS: I'm on OS 7, but I think Alt was generally used for such purpose (maybe in other DEs). I never used it though, not a fan of mouse+keyboard combos...

jeremypw commented 2 months ago

@janxkoci Using the current main branch on OS8 It seems that you can drag on the pathbar in some cases:

If you click on the white space after the breadcrumbs the it switches to edit mode (which is intentional) and you cannot drag in edit mode.

Can probably fix this by switching on button release instead of button press and only switch to edit mode if no drag occurred.

janxkoci commented 2 months ago

@jeremypw I can confirm it behaves the same on OS 7, thanks for pointing it out.

PS: even the tooltip changes to indicate different actions in different parts of the path bar. I just never wait for tooltips to appear...