elementary / files

File browser designed for elementary OS
https://elementary.io
GNU General Public License v3.0
330 stars 77 forks source link

It is not obvious where arrow keys navigate to (column mode) #691

Open eljefuri opened 6 years ago

eljefuri commented 6 years ago

Lets say that I have highlighted one of the default folders in the sidebar, and then I press the right arrow key → with the intention of entering into keyboard navigation in that folder. There is no visual indication that I have done this, but I can then press the down arrow ↓ and it is then apparent where I am. The same is true within columns. Pressing the right arrow into a folder does not give any visual indication that my arrow key navigation is now constrained to that subfolder. In macOS Finder, there is always an indicator. This issue is probably related to #690

Thank you for reading and for your consideration of the issue.

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/65113733-it-is-not-obvious-where-arrow-keys-navigate-to-column-mode?utm_campaign=plugin&utm_content=tracker%2F65602118&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F65602118&utm_medium=issues&utm_source=github).
jeremypw commented 6 years ago

It sounds like you prefer keyboard operation rather than mouse and it is true that less work is done to optimise keyboard operation than mouse operation. As you say this issue is related to the whole matter of how to visually indicate (and distinguish) keyboard focus, cursor position, hovered items, selected items etc.

eljefuri commented 6 years ago

Yes, it sounds like it. Where can I go to discuss this sort of design, or would that happen in this thread?

jeremypw commented 6 years ago

I am not sure what you meant by constrained to that sub-folder. Pressing left should navigate to the previous column and pressing right (on a folder) should open another subfolder.

When the keyboard focus is in a column where no item is selected, the cursor position is indicated by highlighting the icon (may not be very obvious). At least, this happens in the master version.

jeremypw commented 6 years ago

Actually, this may be more related to #552. See also #473.

If you feel there is a distinct issue here please let me know, otherwise I'll mark this as duplicate and further discussion can take place in the original report.

You can have general discussions on design on the Slack UX Channel, if you have access, or one of the elementary social forums, I guess. If there is a clear pathway/consensus then a project can be created.

eljefuri commented 6 years ago

Thanks for that @jeremypw I think they are indeed both related to this but I am not sure if one or the other is more relevant, or if I am pointing out something more specifically nuanced regarding keyboard navigation.

Regarding the discussion: Slack is really not a good medium to have a fixed, lengthy discussion which is easily able to be referenced or commented upon over time. We need something like a forum, which is what GitHub issues helpfully provides -- although I get the fine line. The Elementary social forums are also not ideal because apparently the developers do not often comment on them. GitHub is really the best place for this that I have seen, unless there is an active Discord or equivalent forum somewhere which the developers also frequent? Any comment @danrabbit ?

jeremypw commented 6 years ago

I would not be averse to creating a project "Make Files more suitable for power users", but even projects do not have anywhere for general discussion. They just link together a number of specific issues (which could be wishlist type) where specific discussions could take place. We still receive comments on closed issues (at least, I do) so discussion can continue there, but it is not discoverable by others outside elementary.

eljefuri commented 6 years ago

@jeremypw This veers quickly off-topic, but I want to suggest in the case of open discussions that maybe a special GitHub tag is constructed for this purpose: "discussion" or "broad topic" or something. The idea being that things tagged with that come with certain rules, such as a limited period of time in which they can be an "open" issue (say, 1 month maximum). This would be a compromise for both sides that at least I find acceptable for now.

jeremypw commented 6 years ago

That is something I considered but I don't know how it would go down with the rest of the team. Launchpad had a tag 'Opinion' that could be used for a similar purpose so there is a precedent.

eljefuri commented 6 years ago

@jeremypw I think the tag "Opinion" would be perfect if it had a 1-month discussion shelf life or so, to at least give it exposure (and after that conversation could still be continued in the closed issue).

jeremypw commented 1 year ago

If desired, a Discussion could be opened around this and related issues of file item styling.

danirabbit commented 1 year ago

I think this is also a duplicate of #473. Files is using a custom focus style that is pretty hard to see in column view

jeremypw commented 1 year ago

I think these issues are more specific effects of the more general issue mentioned in #473. #473 might be better as a project?