elementary / gala

Gala Window Manager for elementary OS and Pantheon
https://elementary.io
GNU General Public License v3.0
273 stars 77 forks source link

Better post-screenshot animation #1661

Open sudoxey opened 1 year ago

sudoxey commented 1 year ago

Problem

Right now there's a short milliseconds of fading animation for screenshot. This sometimes cause slow person like me to not notice the screenshot was already taken and made me press F12 again to be sure. In the end there's a lot of housekeeping needed to be done instead of making my life easier.

Proposal

I wish to team could add a better animation for more feedback/impact such as a short zoom in/out like those of the iOS or Android so that the end user will notice this process has gone through. Something like adding a trash can button would also give better control but not necessary since there's already a screenshot app available. I just need the animation feedback to give more impact, very important for old dude with a lag brain like me.

Prior Art (Optional)

iOS/Android screenshot animation.

HutspotMuts commented 1 year ago

So I saw this "Needs design" and I have been thinking a while about it, and this is what I came up with. (Please excuse my terrible drawing skills) After taking a screenshot, the "screenshot" sound plays and notification-like bar appears in the top-right corner of the screen. On the left is a thumbnail of the screenshot. On the right are three options, displayed as icons: save to clipboard, save to folder (which opens up a system dialog to select the folder) and a trash icon, which moves the screenshot to the trashcan. When the user doesn't interact with it in 10 to 15 seconds it disappears and is saved the same way screenshots are currently saved. If this change is implemented, I would suggest to completely remove the flashing light as it can be a bit bright for people working in a dark environment and can cause possible harm when used by people suffering from photosensitive epilepsy. screenshotconcept

lenemter commented 1 year ago

@HutspotMuts I think instead of designing new notifications specifically for screenshots we can just use system notifications? What do you think about this:

image

HutspotMuts commented 1 year ago

@lenemter That looks very promising! However, is not fully clear to me what exactly would happen here. Is the screenshot automatically saved to the clipboard? If so, that could be incorporated in one notification with extra text, like:

Screenshot Taken

Screenshot is saved to clipboard and screenshots folder.

Otherwise would you always receive two notifications? That would seem a little cluttered to me. Something else to think about is the sound that would be played. I think it would be best to keep the current screenshot sound as the notification pops up, to make it extra clear you're making a screenshot. What do you think about this? And do you know if this is possible with the current notification system? Also, can you tell me how you create these prototypes? They look very good and I'm quite new to designing.

lenemter commented 1 year ago

@HutspotMuts Oops sorry for not answering. These two notifications are supposed to be completely separate. The first one is for notifications saved to folder, the second one if it was saved to clipboard.

What do you think about this? And do you know if this is possible with the current notification system?

Well, we can just silence these notifications in the server.

Also, can you tell me how you create these prototypes? They look very good and I'm quite new to designing.

I sent this notifications from code. You can read more at our developer documentation https://docs.elementary.io/develop/

danirabbit commented 1 year ago

Just wanna link #137 and also https://github.com/elementary/screenshot/pull/253

I agree a notification here is the way to go