elementary / gala

Gala Window Manager for elementary OS and Pantheon
https://elementary.io
GNU General Public License v3.0
275 stars 77 forks source link

Fix panel sometimes being behind windows #2094

Closed leolost2605 closed 4 weeks ago

leolost2605 commented 1 month ago

Fixes #2080

leolost2605 commented 1 month ago

Yeah probably I'm just not sure where would be best. I guess we should connect to some event but which? We could do focus on the window but that only works because we know the wingpanel implementation and that it requests focus every time it goes out of it's reserved space :shrug: Any ideas?

lenemter commented 1 month ago

I have no idea either. I think we should add // FIXME here and just merge it. We can fix wingpanel issue later as it's not critical.

TomiOhl commented 1 month ago

Note that even on "stock" Horus (and nothing compiled from source) the application menu is behind maximized windows, so it's not a new issue and not related to new changes

leolost2605 commented 1 month ago

I have no idea either. I think we should add // FIXME here and just merge it. We can fix wingpanel issue later as it's not critical.

I did that now so it updates visible on focused which should fix the wingpanel issue for now

leolost2605 commented 4 weeks ago

Note that even on "stock" Horus (and nothing compiled from source) the application menu is behind maximized windows, so it's not a new issue and not related to new changes

Hmm I don't remember that. Maybe you mean fullscreen windows so that wingpanel isn't visible at all?

TomiOhl commented 4 weeks ago

Note that even on "stock" Horus (and nothing compiled from source) the application menu is behind maximized windows, so it's not a new issue and not related to new changes

Hmm I don't remember that. Maybe you mean fullscreen windows so that wingpanel isn't visible at all?

Oh yes I mean fullscreen, when wingpanel isn't visible. Then if I press Super + space to open the application menu, it opens behind the window (I can search and launch apps via the keyboard). Doesn't happen if the app is just maximized and wingpanel is still visible, in that case the application menu appears above the window. Got a little confused by the terms, sorry