elementary / granite

Library that extends GTK with common widgets and utilities
https://elementary.io
GNU Lesser General Public License v3.0
280 stars 60 forks source link

GIR warnings #366

Open worldofpeace opened 4 years ago

worldofpeace commented 4 years ago

Describe the bug

Building the latest released granite I see these warnings in the build output

../lib/Services/Application.vala:21.1-21.26: warning: Namespace Services does not have a GIR namespace and version annotation
namespace Granite.Services {
^^^^^^^^^^^^^^^^^^^^^^^^^^
../lib/GtkPatch/AboutDialog.vala:23.1-23.54: warning: Namespace GtkPatch does not have a GIR namespace and version annotation
public class Granite.GtkPatch.AboutDialog : Gtk.Dialog {
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../lib/Drawing/BufferSurface.vala:25.1-25.25: warning: Namespace Drawing does not have a GIR namespace and version annotation
namespace Granite.Drawing {
^^^^^^^^^^^^^^^^^^^^^^^^^
../lib/Widgets/AboutDialog.vala:22.1-22.25: warning: Namespace Widgets does not have a GIR namespace and version annotation
namespace Granite.Widgets {

Platform Information

NixOS 20.30 (development).

Please check what applies: -->

ricotz commented 4 years ago

Preferably granite should not contain nested namespaces at all. Those are not supported by the GIR format and vala isnt fully capable to transform those. https://gitlab.gnome.org/GNOME/vala/issues/541

raggesilver commented 4 years ago

I'm currently not able to generate my project's gir file because of this.

Could not find GIR file 'GraniteServices-1.0.gir'; check XDG_DATA_DIRS or use --includedir

This file most likely doesn't exist and is just an issue related to nested namespaces, correct? Anything I can do about it?