elementary / granite

Library that extends GTK with common widgets and utilities
https://elementary.io
GNU Lesser General Public License v3.0
280 stars 61 forks source link

Custom back-button widget #484

Open hanaral opened 3 years ago

hanaral commented 3 years ago

Problem

The current solution isn't a long term one, and it likely going to look weird to new users who don't see icons inside buttons anywhere else.

Proposal

Now that libadwaita is a thing, I don't see why Granite shouldn't be able to actually function like a custom library with its own custom widgets. Since flatpak allows apps to bring the elementary stylesheet with them on other platforms the way they look shouldn't be too much of an issue anyway.

Prior Art

A quick mock-up:

granite-back-button

cassidyjames commented 3 years ago

There was never anything stopping this technically, someone just needs to write the widget and ensure it picks up style and everything correctly. I do like the shaped button more than the icon button. 🙂

hanaral commented 3 years ago

There was never anything stopping this technically, someone just needs to write the widget and ensure it picks up style and everything correctly. I do like the shaped button more than the icon button. slightly_smiling_face

Just to confirm, were talking about the same thing (custom widget drawing) here, right? Maybe someone could kick this off by looking at how libhandy/adwaita does it, since they have plenty of custom stuff!

Edit: also what was with the bountysource plugin still adding stuff to my issue

cassidyjames commented 3 years ago

Just to confirm, were talking about the same thing (custom widget drawing) here, right? Maybe someone could kick this off by looking at how libhandy/adwaita does it, since they have plenty of custom stuff!

Yes. I think the issue is knowing how the border and shadows should work with an angled button, but I'm not personally familiar with how custom drawing works.