search

elementary / greeter

Login and Lock Screen greeter for elementary OS and Pantheon, using LightDM
GNU General Public License v3.0
152 stars 39 forks source link

No Wingpanel in LigthDM Greeter #178

Closed yellowgh0st closed 5 years ago

yellowgh0st commented 5 years ago

There's no more Wingpanel in LightDM Greeter.

Here's /var/log/lightdm/seat0-greeter.log which seems interessting: https://hastebin.com/raw/yonaqareke

Another one here: https://hastebin.com/raw/kiciyaliga

So these packages are causing the crash and are flatpak dependencies:

xdg-desktop-portal xdg-desktop-portal-gtk

$ sudo cat /var/log/lightdm/seat0-greeter.log | grep wingpanel
(wingpanel:13480): Gtk-CRITICAL **: 00:16:23.561: gtk_widget_set_no_show_all: assertion 'GTK_IS_WIDGET (widget)' failed
(wingpanel:13480): Gtk-CRITICAL **: 00:16:23.561: gtk_widget_show_all: assertion 'GTK_IS_WIDGET (widget)' failed
(wingpanel:13480): GLib-GObject-WARNING **: 00:16:23.564: invalid (NULL) pointer instance
(wingpanel:13480): GLib-GObject-CRITICAL **: 00:16:23.564: g_signal_connect_object: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed
(wingpanel:13480): GLib-GObject-WARNING **: 00:16:23.564: invalid (NULL) pointer instance
(wingpanel:13480): GLib-GObject-CRITICAL **: 00:16:23.564: g_signal_connect_object: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed
(wingpanel:13480): GLib-GObject-WARNING **: 00:16:46.175: invalid (NULL) pointer instance
(wingpanel:13480): GLib-GObject-CRITICAL **: 00:16:46.175: g_signal_connect_object: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed
** (wingpanel:13480): CRITICAL **: 00:16:46.177: session_services_user_manager_update_all: assertion 'self != NULL' failed
Nine-H commented 5 years ago

I was about to report this. can you reboot your computer, note if the panel is displayed, and then lock it and note whether it was displayed again?

I only get the panel on first boot.

yellowgh0st commented 5 years ago

No, it's not displayed either after reboot and lock, but one time I woke up my system from suspended state and It was there. Then after unlock the instance crashed again.

I have added another log...

@Nine-H Can you post your log?

peteruithoven commented 5 years ago

@4ugustin could you try honing in on what package specifically causes issue. Does the issue disappear when you remove those packages?

yellowgh0st commented 5 years ago

@peteruithoven Nice I found them for first shot. Purged dependencies of flatpak and It does work as is expected again without crash.

These packages are causing the crash: xdg-desktop-portal xdg-desktop-portal-gtk

It should be reproducible by:

sudo apt install xdg-desktop-portal xdg-desktop-portal-gtk

When xdg-desktop-portal is installed without xdg-desktop-portal-gtk it doesn't happen.

Then wingpanel instance doesn't start within LightDM.

https://github.com/flatpak/xdg-desktop-portal-gtk https://github.com/flatpak/xdg-desktop-portal

Nine-H commented 5 years ago

I got an email about flatpak but it's not in the issue thread. Yeah, I have flatpak installed to pull down a couple of GNOME apps.

yellowgh0st commented 5 years ago

@Nine-H I deleted it because I found that the issue Is caused by flatpak's dependencies as it's mentioned above. Current workaround is to purge these packages (and flatpak).

yellowgh0st commented 5 years ago

I asked on #flatpak for help:

< mclasen> crmlt: thats a gtk bug. I thought this was fixed in 3.24.x. which version of gtk ? < crmlt> mclasen: libgtk-3-0 3.22.30-1ubuntu1 < mclasen> I would suggest trying 3.24.1 and see if the issue goes away

peteruithoven commented 5 years ago

You could also try disabling individual indicators so see which one has an issue with flatpak. It looks like the individual indicators are installed to /usr/lib/x86_64-linux-gnu/wingpanel (assuming you're running a x86 64bit system). You could try renaming some of these from *.so to something like *.backup.

yellowgh0st commented 5 years ago

@peteruithoven Tried disabling them one by one but found nothing.

yellowgh0st commented 5 years ago

Still happens with compiled #181 now 45167e58907e8e53779f18eb173eeb929f406af5 So probably it's really a gtk bug and thus will be unfixed until there will be libgtk 3.24.1 in ubuntu repos.

raymanfx commented 5 years ago

FYI the same issue is present on Fedora 29 with GTK 3.24.1.

worldofpeace commented 5 years ago

@peteruithoven Any suggesting an any actions to take? I'm willing to help with debugging if time is permissible.

Also pinging @tintou

peteruithoven commented 5 years ago

It's weird that this would only happen in the greeter.

It's started here: https://github.com/elementary/greeter/blob/master/src/Application.vala#L41 Would be great if we could get some more debug information from it, a bit like we normally can by running a process from the terminal with: G_MESSAGES_DEBUG=all theprocess or using gdb.

I've been able to get more debug info from Greeter with some hacks in the past, but I really hope there is a better way. Normally logs seem to be accessible through journalctl, maybe there is a way to change the debug level on a per application basis.

worldofpeace commented 5 years ago

It's weird that this would only happen in the greeter.

It's started here: https://github.com/elementary/greeter/blob/master/src/Application.vala#L41 Would be great if we could get some more debug information from it, a bit like we normally can by running a process from the terminal with: G_MESSAGES_DEBUG=all theprocess or using gdb.

I've been able to get more debug info from Greeter with some hacks in the past, but I really hope there is a better way. Normally logs seem to be accessible through journalctl, maybe there is a way to change the debug level on a per application basis.

Thanks for the tips. I'm willing to try anything at this point so lets see what this yields.

janxkoci commented 5 years ago

If I understand this issue correctly, at this moment I have a choice between wingpanel in greeter or my flatpak apps, as purging the two dependencies would break them, right?

janxkoci commented 5 years ago

I got some updates lately and today when unlocking the screen I noticed icons in the top right corner of my lock screen, just before I hit enter to confirm password. They were white on my light wallpaper (in session I have them black) but with a shadow, so quite visible. I tried to lock the screen again to try take a screenshot but they were gone :/

I locked the screen with keybord shortcut Super+L both times, however the first time after waking up the screen I had focus, while the second time (with icons missing) I didn't have focus, so it might be related to bug #144.

jeremypw commented 5 years ago

I found that the wingpanel appears after waiting 20 - 30 seconds. Do you find this? I am about to propose a PR to fix this.

janxkoci commented 5 years ago

Right now I mostly see it straight away (I was away for a week and returned few days ago, then installed updates), but I will watch out for this.

jeremypw commented 5 years ago

These race condition related issues often affect different systems differently.