elementary / greeter

Login and Lock Screen greeter for elementary OS and Pantheon, using LightDM
GNU General Public License v3.0
152 stars 39 forks source link

Lock guest session creates orphaned sessions #460

Open mcclurgm opened 4 years ago

mcclurgm commented 4 years ago

Prerequisites

Not sure if this is the place for this bug, so please move it if I got that wrong. :slightly_smiling_face:

Describe the bug

When I lock a guest session (using the Lock option in Wingpanel, or closing the lid, or simply not interacting for too long and timing out), there's no way to access it again. However, it's left running.

To Reproduce

Steps to reproduce the behavior:

  1. From the greeter, open a guest session.
  2. Lock the computer. Click Lock from Wingpanel, put it to sleep, press a lock button, time out the session, whatever you like.
  3. Repeat any number of times you choose, at least 2.
  4. From your own account, open the terminal and run the w command. You should see one guest session still active for every time you created a new one.

Here's an example of what the output looks like when I opened 2 guest sessions:

Downloads ❯ w
 15:27:13 up 22:30,  3 users,  load average: 0.59, 0.81, 0.63
USER     TTY      FROM             LOGIN@   IDLE   JCPU   PCPU WHAT
michael  tty7     :0               Thu16   22:30m 10:52   0.45s /usr/lib/gnome-session/gnome-session-binary --session=pantheon
guest-cs tty8     :1               09:33   22:30m  6.85s  0.25s /usr/lib/gnome-session/gnome-session-binary --session=pantheon
guest-oh tty9     :2               15:02   22:30m 18.11s  0.17s /usr/lib/gnome-session/gnome-session-binary --session=pantheon

Expected behavior

Either these sessions should be ended (with a warning) or there should be a way to access them again.

Platform Information

about

Additional context

In my opinion, locking and opening should have a way to go back to the same session. Otherwise, there should be no lock function in a guest session and we should disable all the places where it appears. It's inconvenient opening up a guest session and doing work, then going away for just a bit too long and losing whatever I was doing.