search

elementary / greeter

Login and Lock Screen greeter for elementary OS and Pantheon, using LightDM
GNU General Public License v3.0
152 stars 39 forks source link

Fix delayed time update after resuming from sleep #472

Closed vjr closed 3 years ago

vjr commented 4 years ago

Fix #306 Fix #383

vjr commented 4 years ago

@tintou or @davidmhewitt would you please take a look to help me figure out why I'm unable to capture the PrepareForSleep signal coming from the org.freedesktop.login1.Manager dbus interface?

I have placed a couple of warning level logs with my initials VJR which are not being logged although I do get the log from update_time ()

Thanks!

vjr commented 4 years ago

Ready for review!

vjr commented 3 years ago

I've left a code suggestion that should make your async method a lot more readable. Could you test that it's functionally equivalent?

Thanks! I've updated the code and it works as expected.

vjr commented 3 years ago

Nice work!

Sorry it took so long to review, and thank you for your patience and quick responses to my code reviews.

Not at all, I'm the one who should be thanking you for the repeated and patient code reviews, so thank you!

gniezen commented 3 years ago

This is very exciting, I'm looking forward to see the correct time on my login screen. Thanks for your work on this!