search

elementary / greeter

Login and Lock Screen greeter for elementary OS and Pantheon, using LightDM
GNU General Public License v3.0
151 stars 39 forks source link

Add button to open terminal #501

Closed meisenzahl closed 3 years ago

meisenzahl commented 3 years ago

Closes https://github.com/elementary/greeter/issues/497

meisenzahl commented 3 years ago

Adds a button that should open a terminal when clicked. Unfortunately, the terminal does not open at the moment.

Bildschirmfoto von 2021-01-17 08 02 27

@danrabbit I copied your code to open io.elementary.initial-setup and adapted it so that io.elementary.terminal should be started. Unfortunately this does not work. Do you remember if you had problems back then and had to configure something special for io.elementary.initial-setup?

hanaral commented 3 years ago

This is supposed to be an OSusable by anyone, adding a big ass terminal button to the bottom of the login screen is asking for trouble. How about making it a specific keybind instead?

meisenzahl commented 3 years ago

Currently it is in the style of the other buttons like "Log in as Guest" and "Manual Login...". I am not sure what the final design will look like. But we already have keybindings to open a terminal Ctrl+Alt+F1-F6. So I think a button, in whatever form, makes sense.

But I'm not the right one to decide that, so I'm looking forward to feedback from @elementary/ux.

cassidyjames commented 3 years ago

I'm really :-1: on adding a way to open Terminal from the greeter; that seems like an invitation to way too much trouble. For extreme recovery needs (like a non-launching session), there is already recovery mode when booting and the TTY.