elementary / greeter

Login and Lock Screen greeter for elementary OS and Pantheon, using LightDM
GNU General Public License v3.0
152 stars 39 forks source link

support libmutter-11 #617

Closed decathorpe closed 2 years ago

decathorpe commented 2 years ago

Yup, It's that time of the year again 😞

A few days ago, mutter 43.alpha has been released with a library bump from libmutter-10 to libmutter-11.

The new version was pushed to Fedora Rawhide earlier today, so as soon as the repositories / ISOs are regenerated tomorrow, it should be a good way to test gala changes that are necessary to support the new version.

Let me know if I can help with build / testing in any way.

bobby285271 commented 2 years ago

It looks like this is still an issue with vapi files copied from https://github.com/elementary/gala/pull/1457 and meson.build updated:

[209/241] Compiling Vala source ../compositor/BackgroundManager.vala ../compositor/BackgroundUtils.vala ../compositor/DBus.vala ../compositor/DBusAccelerator.vala ../compositor/DBusBackgroundManager.vala ../compositor/KeyboardManager.vala ../compositor/main.vala ../compositor/MediaFeedback.vala ../compositor/SystemBackground.vala ../compositor/Utils.vala ../compositor/WindowManager.vala config.vala
FAILED: compositor/io.elementary.greeter-compositor.p/BackgroundManager.c compositor/io.elementary.greeter-compositor.p/BackgroundUtils.c compositor/io.elementary.greeter-compositor.p/DBus.c compositor/io.elementary.greeter-compositor.p/DBusAccelerator.c compositor/io.elementary.greeter-compositor.p/DBusBackgroundManager.c compositor/io.elementary.greeter-compositor.p/KeyboardManager.c compositor/io.elementary.greeter-compositor.p/main.c compositor/io.elementary.greeter-compositor.p/MediaFeedback.c compositor/io.elementary.greeter-compositor.p/SystemBackground.c compositor/io.elementary.greeter-compositor.p/Utils.c compositor/io.elementary.greeter-compositor.p/WindowManager.c compositor/io.elementary.greeter-compositor.p/config.c 
valac -C --vapidir /build/greeter/vapi --pkg mutter-clutter-11 --pkg mutter-cogl-pango-11 --pkg mutter-cogl-11 --pkg libmutter-11 --pkg posix --pkg gee-0.8 --pkg gdk-x11-3.0 --pkg gtk+-3.0 --pkg gmodule-2.0 --pkg gio-unix-2.0 --pkg gio-2.0 --color=always --directory compositor/io.elementary.greeter-compositor.p --basedir ../compositor --gresources=../data/compositor.gresource.xml --define HAS_MUTTER338 --define HAS_MUTTER40 --define HAS_MUTTER41 --define HAS_MUTTER42 --define HAS_MUTTER43 ../compositor/BackgroundManager.vala ../compositor/BackgroundUtils.vala ../compositor/DBus.vala ../compositor/DBusAccelerator.vala ../compositor/DBusBackgroundManager.vala ../compositor/KeyboardManager.vala ../compositor/main.vala ../compositor/MediaFeedback.vala ../compositor/SystemBackground.vala ../compositor/Utils.vala ../compositor/WindowManager.vala config.vala
../compositor/WindowManager.vala:426.23-426.38: error: The name `show_dialog' does not exist in the context of `Meta.Util' (libmutter-11)
  426 |             var pid = Util.show_dialog ("--question",
      |                       ^~~~~~~~~~~~~~~~               
../compositor/WindowManager.vala:439.26-439.50: warning: `GLib.Process.check_exit_status' has been deprecated since 2.70. Use check_wait_status
  439 |                     ok = Process.check_exit_status (status);
      |                          ^~~~~~~~~~~~~~~~~~~~~~~~~          
Compilation failed: 1 error(s), 1 warning(s)
[210/241] Compiling Vala source ../src/Application.vala ../src/FPrintUtils.vala ../src/MainWindow.vala ../src/PantheonAccountsServicePlugin.vala ../src/PromptText.vala ../src/SettingsDaemon.vala ../src/Settings.vala ../src/SubprocessSupervisor.vala ../src/Cards/BaseCard.vala ../src/Cards/ManualCard.vala ../src/Cards/UserCard.vala ../src/Widgets/BackgroundImage.vala ../src/Widgets/CapsLockRevealer.vala ../src/Widgets/DateTimeWidget.vala ../src/Widgets/PasswordEntry.vala ../src/Widgets/SessionButton.vala config.vala
ninja: build stopped: subcommand failed.

Related code: https://github.com/elementary/greeter/blob/6.1.0/compositor/WindowManager.vala#L426

Likely the related upstream commit is this one and a copy paste of https://github.com/elementary/gala/pull/1327 should workaround the issue.