search

elementary / greeter

Login and Lock Screen greeter for elementary OS and Pantheon, using LightDM
GNU General Public License v3.0
152 stars 39 forks source link

Support dark mode #684

Open lenemter opened 1 year ago

lenemter commented 1 year ago

Fixes https://github.com/elementary/greeter/issues/688 Closes #563 Closes #499

To do:

BAProductions commented 1 year ago

Close my commit well

danirabbit commented 8 months ago

Testing this with the latest settings-daemon, I am now getting a blank screen on the greeter :grimacing: Does this need to be updated too?

lenemter commented 8 months ago

That's weird. Have you installed https://github.com/elementary/wingpanel/pull/499 by any chance? If you have, try uninstalling it.

lenemter commented 8 months ago

I fixed a bug that prevented setting user preferences, everything should work as expected now.

danirabbit commented 7 months ago

Sorry for taking a while to respond! Just tried again on a relatively clean OS 8 install where I have not had that wingpanel branch and I'm still getting a blank/gray screen with this branch. So it seems like the compositor is probably loading but not the panel or greeter window

lenemter commented 7 months ago

@danirabbit Not sure what might have caused that. Can you send me logs from /var/log/lightdm/seat0-greeter.log please?

danirabbit commented 7 months ago

@lenemter sorry for taking a while to follow up!

``` (io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:05.863: g_variant_new_string: assertion 'string != NULL' failed (io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:05.863: g_variant_ref_sink: assertion 'value != NULL' failed (io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:05.863: g_variant_ref_sink: assertion 'value != NULL' failed (io.elementary.greeter:39487): GLib-GIO-CRITICAL **: 10:02:05.863: g_settings_schema_key_type_check: assertion 'value != NULL' failed (io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:05.863: g_variant_get_type_string: assertion 'value != NULL' failed (io.elementary.greeter:39487): GLib-GIO-CRITICAL **: 10:02:05.863: g_settings_set_value: key 'document-font-name' in 'org.gnome.desktop.interface' expects type 's', but a GVariant of type '(null)' was given (io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:05.863: g_variant_unref: assertion 'value != NULL' failed (io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:05.865: g_variant_new_string: assertion 'string != NULL' failed (io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:05.865: g_variant_ref_sink: assertion 'value != NULL' failed (io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:05.865: g_variant_ref_sink: assertion 'value != NULL' failed (io.elementary.greeter:39487): GLib-GIO-CRITICAL **: 10:02:05.865: g_settings_schema_key_type_check: assertion 'value != NULL' failed (io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:05.865: g_variant_get_type_string: assertion 'value != NULL' failed (io.elementary.greeter:39487): GLib-GIO-CRITICAL **: 10:02:05.865: g_settings_set_value: key 'font-name' in 'org.gnome.desktop.interface' expects type 's', but a GVariant of type '(null)' was given (io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:05.865: g_variant_unref: assertion 'value != NULL' failed (io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:05.866: g_variant_new_string: assertion 'string != NULL' failed (io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:05.866: g_variant_ref_sink: assertion 'value != NULL' failed (io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:05.866: g_variant_ref_sink: assertion 'value != NULL' failed (io.elementary.greeter:39487): GLib-GIO-CRITICAL **: 10:02:05.866: g_settings_schema_key_type_check: assertion 'value != NULL' failed (io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:05.866: g_variant_get_type_string: assertion 'value != NULL' failed (io.elementary.greeter:39487): GLib-GIO-CRITICAL **: 10:02:05.866: g_settings_set_value: key 'monospace-font-name' in 'org.gnome.desktop.interface' expects type 's', but a GVariant of type '(null)' was given (io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:05.866: g_variant_unref: assertion 'value != NULL' failed ** (io.elementary.greeter:39487): CRITICAL **: 10:02:05.879: MainWindow.vala:350: prompt: `Password: ' (1) ** (io.elementary.greeter:39487): CRITICAL **: 10:02:06.698: MainWindow.vala:350: prompt: `Password: ' (1) (io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:07.364: g_variant_new_string: assertion 'string != NULL' failed (io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:07.364: g_variant_ref_sink: assertion 'value != NULL' failed (io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:07.364: g_variant_ref_sink: assertion 'value != NULL' failed (io.elementary.greeter:39487): GLib-GIO-CRITICAL **: 10:02:07.364: g_settings_schema_key_type_check: assertion 'value != NULL' failed (io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:07.364: g_variant_get_type_string: assertion 'value != NULL' failed (io.elementary.greeter:39487): GLib-GIO-CRITICAL **: 10:02:07.364: g_settings_set_value: key 'document-font-name' in 'org.gnome.desktop.interface' expects type 's', but a GVariant of type '(null)' was given (io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:07.364: g_variant_unref: assertion 'value != NULL' failed (io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:07.367: g_variant_new_string: assertion 'string != NULL' failed (io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:07.367: g_variant_ref_sink: assertion 'value != NULL' failed (io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:07.367: g_variant_ref_sink: assertion 'value != NULL' failed (io.elementary.greeter:39487): GLib-GIO-CRITICAL **: 10:02:07.367: g_settings_schema_key_type_check: assertion 'value != NULL' failed (io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:07.367: g_variant_get_type_string: assertion 'value != NULL' failed (io.elementary.greeter:39487): GLib-GIO-CRITICAL **: 10:02:07.367: g_settings_set_value: key 'font-name' in 'org.gnome.desktop.interface' expects type 's', but a GVariant of type '(null)' was given (io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:07.367: g_variant_unref: assertion 'value != NULL' failed (io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:07.369: g_variant_new_string: assertion 'string != NULL' failed (io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:07.369: g_variant_ref_sink: assertion 'value != NULL' failed (io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:07.369: g_variant_ref_sink: assertion 'value != NULL' failed (io.elementary.greeter:39487): GLib-GIO-CRITICAL **: 10:02:07.369: g_settings_schema_key_type_check: assertion 'value != NULL' failed (io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:07.369: g_variant_get_type_string: assertion 'value != NULL' failed (io.elementary.greeter:39487): GLib-GIO-CRITICAL **: 10:02:07.369: g_settings_set_value: key 'monospace-font-name' in 'org.gnome.desktop.interface' expects type 's', but a GVariant of type '(null)' was given (io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:07.369: g_variant_unref: assertion 'value != NULL' failed ** (io.elementary.greeter:39487): CRITICAL **: 10:02:07.379: MainWindow.vala:350: prompt: `Password: ' (1) ** (io.elementary.greeter:39487): CRITICAL **: 10:02:08.084: MainWindow.vala:350: prompt: `Password: ' (1) (io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:08.866: g_variant_new_string: assertion 'string != NULL' failed (io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:08.866: g_variant_ref_sink: assertion 'value != NULL' failed (io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:08.866: g_variant_ref_sink: assertion 'value != NULL' failed (io.elementary.greeter:39487): GLib-GIO-CRITICAL **: 10:02:08.866: g_settings_schema_key_type_check: assertion 'value != NULL' failed (io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:08.866: g_variant_get_type_string: assertion 'value != NULL' failed (io.elementary.greeter:39487): GLib-GIO-CRITICAL **: 10:02:08.866: g_settings_set_value: key 'document-font-name' in 'org.gnome.desktop.interface' expects type 's', but a GVariant of type '(null)' was given (io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:08.866: g_variant_unref: assertion 'value != NULL' failed (io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:08.868: g_variant_new_string: assertion 'string != NULL' failed (io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:08.868: g_variant_ref_sink: assertion 'value != NULL' failed (io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:08.868: g_variant_ref_sink: assertion 'value != NULL' failed (io.elementary.greeter:39487): GLib-GIO-CRITICAL **: 10:02:08.868: g_settings_schema_key_type_check: assertion 'value != NULL' failed (io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:08.868: g_variant_get_type_string: assertion 'value != NULL' failed (io.elementary.greeter:39487): GLib-GIO-CRITICAL **: 10:02:08.868: g_settings_set_value: key 'font-name' in 'org.gnome.desktop.interface' expects type 's', but a GVariant of type '(null)' was given (io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:08.868: g_variant_unref: assertion 'value != NULL' failed (io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:08.878: g_variant_new_string: assertion 'string != NULL' failed (io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:08.878: g_variant_ref_sink: assertion 'value != NULL' failed (io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:08.878: g_variant_ref_sink: assertion 'value != NULL' failed (io.elementary.greeter:39487): GLib-GIO-CRITICAL **: 10:02:08.878: g_settings_schema_key_type_check: assertion 'value != NULL' failed (io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:08.878: g_variant_get_type_string: assertion 'value != NULL' failed (io.elementary.greeter:39487): GLib-GIO-CRITICAL **: 10:02:08.878: g_settings_set_value: key 'monospace-font-name' in 'org.gnome.desktop.interface' expects type 's', but a GVariant of type '(null)' was given (io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:08.878: g_variant_unref: assertion 'value != NULL' failed ** (io.elementary.greeter:39487): CRITICAL **: 10:02:08.886: MainWindow.vala:350: prompt: `Password: ' (1) ** (io.elementary.greeter:39487): CRITICAL **: 10:02:09.767: MainWindow.vala:350: prompt: `Password: ' (1) (io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:10.550: g_variant_new_string: assertion 'string != NULL' failed (io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:10.550: g_variant_ref_sink: assertion 'value != NULL' failed (io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:10.550: g_variant_ref_sink: assertion 'value != NULL' failed (io.elementary.greeter:39487): GLib-GIO-CRITICAL **: 10:02:10.550: g_settings_schema_key_type_check: assertion 'value != NULL' failed (io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:10.550: g_variant_get_type_string: assertion 'value != NULL' failed (io.elementary.greeter:39487): GLib-GIO-CRITICAL **: 10:02:10.550: g_settings_set_value: key 'document-font-name' in 'org.gnome.desktop.interface' expects type 's', but a GVariant of type '(null)' was given (io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:10.550: g_variant_unref: assertion 'value != NULL' failed (io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:10.551: g_variant_new_string: assertion 'string != NULL' failed (io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:10.552: g_variant_ref_sink: assertion 'value != NULL' failed (io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:10.552: g_variant_ref_sink: assertion 'value != NULL' failed (io.elementary.greeter:39487): GLib-GIO-CRITICAL **: 10:02:10.552: g_settings_schema_key_type_check: assertion 'value != NULL' failed (io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:10.552: g_variant_get_type_string: assertion 'value != NULL' failed (io.elementary.greeter:39487): GLib-GIO-CRITICAL **: 10:02:10.552: g_settings_set_value: key 'font-name' in 'org.gnome.desktop.interface' expects type 's', but a GVariant of type '(null)' was given (io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:10.552: g_variant_unref: assertion 'value != NULL' failed (io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:10.553: g_variant_new_string: assertion 'string != NULL' failed (io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:10.553: g_variant_ref_sink: assertion 'value != NULL' failed (io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:10.553: g_variant_ref_sink: assertion 'value != NULL' failed (io.elementary.greeter:39487): GLib-GIO-CRITICAL **: 10:02:10.553: g_settings_schema_key_type_check: assertion 'value != NULL' failed (io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:10.553: g_variant_get_type_string: assertion 'value != NULL' failed (io.elementary.greeter:39487): GLib-GIO-CRITICAL **: 10:02:10.553: g_settings_set_value: key 'monospace-font-name' in 'org.gnome.desktop.interface' expects type 's', but a GVariant of type '(null)' was given (io.elementary.greeter:39487): GLib-CRITICAL **: 10:02:10.553: g_variant_unref: assertion 'value != NULL' failed ```
zeebok commented 4 months ago

@lenemter There is a conflict to resolve now

zeebok commented 3 months ago

I am seeing the same compiler errors as the checks