elementary / greeter

Login and Lock Screen greeter for elementary OS and Pantheon, using LightDM
GNU General Public License v3.0
152 stars 39 forks source link

Add blurred background #698

Closed lenemter closed 4 months ago

lenemter commented 4 months ago

Closes https://github.com/elementary/greeter/pull/358 Closes https://github.com/elementary/greeter/pull/623

Background code was copied from Gala

vjr commented 4 months ago

I tried this branch and it works well for me, so thumbs up from my side. Hopefully this is reviewed/merged :-)

vjr commented 4 months ago

I tried this branch and it works well for me, so thumbs up from my side. Hopefully this is reviewed/merged :-)

Scratch that! This PR seems to break/interfere with the "fade in" PR #697 recently merged. I was looking at a problem on my machine (with AMD RX580 GPU on OS 7.1 daily) with the fade-in being all noise/garbled but only the wallpaper/background, the other elements (ui_group) fade-in properly. I have not yet tested with OS8 ISO.

lenemter commented 4 months ago

@vjr Oops, I'll fix the fade-in animation as soon as I can

danirabbit commented 4 months ago

@vjr since we reverted the fade in for now, does this still break for you?

vjr commented 4 months ago

@danirabbit yes the blank screen issue is still present.

I just now tested on an updated os8 install showing greeter version 7.0.0 r1550 pkg96 daily ubuntu8.1

Same issue after building and installing this branch so I don't think it was the fade-in PR so hopefully it will return in some form because it's cool.

My bad if I misguided y'all with my recent comments about the fadein causing artefacts which was occurring only on my older PC with an AMD RX 580 GPU.

vjr commented 4 months ago

Okay I just tested this branch with one change to move the Gtk.init call a few lines lower in src/Application.vala like was done in the fade in PR and it fixes the blank screen issue.

lenemter commented 4 months ago

@danirabbit I fixed panel contrast here. I'll prepare a branch for syncing the transparency setting later