search

elementary / greeter

Login and Lock Screen greeter for elementary OS and Pantheon, using LightDM
GNU General Public License v3.0
152 stars 39 forks source link

Simpler fade-in animation #703

Closed lenemter closed 4 months ago

lenemter commented 4 months ago

Closes https://github.com/elementary/greeter/pull/702

Uses simpler way to animate fade-in. Should not produce any glitches whatsoever.

vjr commented 4 months ago

I can test this branch and comment later tonight which is about 4 or 5 hours from now.

vjr commented 4 months ago

OK I've observed the following:

This PR works with OS 8 daily on my newer laptop (Ryzen 7840U with 780M iGPU) but not on my older desktop with an AMD RX 580 GPU - the "blank screen" issue persists - actually you can see the user cards stuck in shrunken size very faint though - and just typing password I can login. I wonder if it's something to do with Noble still being in development.

This PR works well on OS 7.1 daily on my older desktop with the AMD RX 580 GPU (where the OS 8 install has the blank screen issue). I do not have OS 7.1 daily on my laptop to test but I have another Ryzen 6800U laptop with 680M iGPU which I can install both daily ISOs of OS 7.1 and 8 and test if not tonight then over the weekend.

I think this PR is OK to merge IMHO both code and behaviour LGTM but I'll leave it to others to also review/test.