search

elementary / icons

Named, vector icons for elementary OS
https://elementary.io
GNU General Public License v3.0
550 stars 85 forks source link

Icon inside the play button not in center #1232

Closed ausdauerer closed 10 months ago

ausdauerer commented 1 year ago

What Happened?

The play icon within the button is slightly to the left. It is not causing any problems, just to improve the aesthetic.

image

Steps to Reproduce

Expected Behavior

Icon in the center of the button

OS Version

7.x (Horus)

Software Version

Latest release (I have run all updates)

Log Output

No response

Hardware Info

No response

newhoa commented 1 year ago

I also noticed a while back that the skip icons are off center. When I looked into this I thought it looked like it was made this way intentionally in order for the arrows of skip and seek to match up if they change from one to the other in-place? (here is an example of seek and skip where skip is edge-aligned in order for the arrows to match up) But I think in cases like OPs image, the skip icons also look slightly off center because of it.

I think the benefits of centering the skip icons outweigh the arrow alignment thing, but that's just my thoughts. Maybe if it were changed it would look a lot more off somewhere else.

Ironically, though, the play icon in OPs picture is actually centered and the others aren't; it's just that the weight-distribution of the play icon is heavily to the left which makes it look off. Just moving it a pixel off-center would make it look more centered.

Here is an example of centering the skip icons, and off-centering the play button: raligned2

But then of course the arrows of the seek and skip icons don't align in the case that they change from one to the other in-place.

If that's not a big deal and it's decided they should be centered I could do a PR for these, just let me know!

Edit: Here is an example of just the play button moved by 1 pixel, the seek buttons left alone for comparison sake.

waldyrious commented 1 year ago

The play triangle is equilateral, right? If so, I think it might be worth making use of the fact that all the ways of defining its center coincide, and shift that point to be at the center of the icon, rather than do an arbitrary shift of 1px. (Though I do agree it looks better already, so that's definitely an improvement.)