search

elementary / icons

Named, vector icons for elementary OS
https://elementary.io
GNU General Public License v3.0
550 stars 84 forks source link

Refresh `go-home` and align with other `go-` icons #1294

Open wpkelso opened 4 months ago

wpkelso commented 4 months ago

Closes #1094

Refreshes go-home to use standard fill color, unifies it's corner radii with other go- icons, and move it's baseline up by two pixels to align with other go- icons

danirabbit commented 3 months ago

It looks like this has conflicts now. Can you resolve those please? :)

danirabbit commented 3 months ago

It also looks like the icon in #1094 is the 24px version, so you'll need to make sure to update that one as well

wpkelso commented 3 months ago

Couple problems here with like positioning and size. If you look at for example the home icon in an entry at 16px, it's really crammed up against the top edge now. It doesn't look vertically centered:

Hmm, that might be an artifact of my misidentifying the problem in the original screenshot. I believe (Ill check a little later) that 'view-refresh' is top aligned when I looked at the file, so I matched that alignment here. Centering home will likely reintroduce the alignment issue present in the screenshot without some compensation in refresh.

Ill fix the alignment here, but I want to do some investigating to see whether all of the view icons are like that.

danirabbit commented 3 months ago

Yeah so, if I remember correctly, the top of the arrow in the refresh icon does reach the top of the canvas, but the actual circular body of the icon is vertically centered. So it's okay to have elements that are like ascenders and descenders, but you also have to make sure the visual weight of the icon is centered