Open cassidyjames opened 4 years ago
I had an idea for this, so I attempted it (probably a bit rough however):
I believe there's several advantages of using individual, generic glyphs for the statuses:
(...maybe these glyphs are too generic however?)
The idea for using the asterisk for the "changed" icon comes from the paradigm of programs prepending an asterisk to the filename in titles and tabs when there are unsaved changes to the file, Code does this if you have autosave disabled for example. So anyone familiar with this convention will probably know what it means.
For the changed icon I also used a very slightly darker shade than Banana 500 for the circle background, the reason for deviating from the palette slightly was to improve the contrast. I took saturation and hue into account.
I initially edited this from the "unreadable file" emblem, so initial versions had longer plus and asterisk glyphs (also the asterisk background here uses Banana 500):
But I felt the asterisk looked... not good, so I shortened it, and then I did the same to the plus icon so it would match better.
If this is liked/deemed suitable in its current state, I can send a PR (and make 8px versions as well so that it can be viewed in smallest
modes too, also see #872).
If you also want to add an emblem to represent removed files that haven't been committed, I can also make one for that (a red background with a cross, or maybe a bin...).
Made a variant with a branch as well, if the above is too generic:
This is very rough draft just as a preview to get the drift of the branch concept. The curved branching line is not right, it might be too "busy" in its current state, maybe arrangement would be changed, maybe I'll try the plus smaller, etc.:
Update:
Okay, adding knobs (like GitHub's branching icons) seems to make it look way better:
Also it's now vertical.
The squiggly line (and maybe the positioning) still need refining.
Edit:
Slightly darkened yellow shade again in order to further improve contrast. Squiggly line is still unrefined. Tried to pixel-fit the asterisk. It may or may not need to be exaggerated more (or the edges flattened more) in order to better differentiate it from the plus icon.
Jeremy pointed me to this issue so I thought I'd put my ideas here too.
I think a more general form for icons would be better than specific ones. They could be used across the system for more use cases than git, but I will post those ideas on the related thread.
As for git status, I think +
, *
, and -
badges to signify additions, changes, and removals would suffice. It should scale pretty well since the symbols would be simple and would help color blind users differentiate between the different dots. I do think the branch icon is nice, but they are really small and I'm not sure they would help color blind users much.
Also related to #827 but specifically for git statuses, i.e. in Files and Code