elementary / initial-setup

New user setup app designed for elementary OS
https://elementary.io
GNU General Public License v3.0
36 stars 12 forks source link

Offer to switch to left-handed setup if right clicking "Next" #133

Closed meisenzahl closed 2 years ago

meisenzahl commented 2 years ago

Closes #132

https://user-images.githubusercontent.com/10796736/146943803-a2dbfb99-435f-41eb-a8d1-db363e913743.mp4

danirabbit commented 2 years ago

Thanks for working on this so quickly! I think we probably also need to have branches for accountsservice and settings daemon to be able to sync this setting to the new user account right?

meisenzahl commented 2 years ago

@danrabbit thank you so much for your attention to detail. It's much more consistent now.

Bildschirmfoto von 2021-12-24 07 19 40

Bildschirmfoto von 2021-12-24 07 19 56

cassidyjames commented 2 years ago

I see what you're doing visually with the left-click being on the left and right-click being on the right, but I think it's deviating from the HIG to try to be too clever. It would probably be more immediately obvious to keep the suggested action in the primary (end) spot, especially when I think about localization and RTL languages… :sweat_smile:

meisenzahl commented 2 years ago

@cassidyjames I hope I got it right :sweat_smile:

Bildschirmfoto von 2022-01-06 21 01 59

Bildschirmfoto von 2022-01-06 21 02 14