search

elementary / initial-setup

New user setup app designed for elementary OS
https://elementary.io
GNU General Public License v3.0
36 stars 12 forks source link

Delete a user if creation fails #138

Closed danirabbit closed 2 years ago

danirabbit commented 2 years ago

What Happened?

I set up my user and got an error that the user wasn't able to be added to the samba share. Initial setup then exited, and I was left stranded with a disabled account.

Steps to Reproduce

No idea how to reproduce the failure, but basically failure states aren't well handled here

Expected Behavior

We probably shouldn't exit Initial Setup here if creation fails: https://github.com/elementary/initial-setup/blob/e34c159d4e5d46b6d74a560ed59c47861c610c5a/src/MainWindow.vala#L93

And we should probably clean up any disabled/failed user accounts

OS Version

7.x (Early Access)

Software Version

Compiled from git

Log Output

No response

Hardware Info

No response

avojak commented 2 years ago

I'm able to reproduce this issue on a VM setup using the OS 7 20220127 daily build. 

GDBus.Error:org.freedesktop.Accounts.Error.Failed: failed to add user avojak to group sambashare: Child process exited with code 1

I'm not sure how to access any log files, but would be happy to do so if told where to look.

ryonakano commented 2 years ago

FYI attaching a screenshot of the error message currently shown in Initial Setup on the daily image:

スクリーンショット 2022-01-30 135621

avojak commented 2 years ago

I'm no longer seeing this error on the latest daily build (20220202)