search

elementary / music

Music player and library designed for elementary OS
https://elementary.io
GNU General Public License v3.0
146 stars 50 forks source link

Remove CDRom plugin #577

Closed danirabbit closed 4 years ago

danirabbit commented 4 years ago

Fixes #561 Fixes #437 Fixes #500

Apparently the CDRom plugin just crashes music altogether. I'm not sure any active developers have an audio CD, a CD Drive, and a will to make this work. So it's probably better to just remove the plugin so at least Music won't crash

jeremypw commented 4 years ago

I still have an old laptop that has a CD drive and some audio CDs so would be able to work on the plugin if there is a demand/will to continue to support CDs. I guess if there are recent reported issues at least some users have attempted to use Music to play an audio CD. I'll see if there is a quick fix to at least stop the app crashing even if it doesnt play the CD.

cassidyjames commented 4 years ago

I'm also totally fine saying that so few developers and users (based on a low number of reports) have and use CDs in their computer that we're removing it, and anyone who wants CD support is welcome to grab an app from AppCenter.

fitojb commented 4 years ago

based on a low number of reports

As always, the fallacy that if few people reports something it sure means nobody uses something. Rolling my eyes.

cassidyjames commented 4 years ago

@fitojb it literally instantly crashed the entire app. So it was unusable anyway, and yet nobody was reporting issues. That's not a fallacy, it's an extremely strong indication of usage based on a decade of experience managing an open source OS.

decathorpe commented 3 years ago

Looks like you forgot to remove the cdrom option choice from meson_options.txt?