search

elementary / music

Music player and library designed for elementary OS
https://elementary.io
GNU General Public License v3.0
146 stars 50 forks source link

Move privacy_mode_enabled to Music.App #593

Closed danirabbit closed 3 years ago

danirabbit commented 4 years ago

Appears to never be used by plugins

jeremypw commented 4 years ago

The plugins can and do save data to disk (but do not check the privacy setting). E.g the LastFM plugin saves cover art (Core.vala line 239 et seq) and the AudioPlayerLibrary updates playlists (AudioPlayerLibrary.vala line 399 et seq). Not sure if these are privacy issues but before making this change should audit whether the any plugins should be using the privacy setting.

jeremypw commented 3 years ago

@danrabbit Are you satisfied that there are no privacy issues regarding the kind of data that plugins save? If so I will approve this.

danirabbit commented 3 years ago

@jeremypw I've started working on a complete rewrite in another branch so I'm kind of indifferent to continuing to refactor here. I'll leave it to your discretion to merge or close

jeremypw commented 3 years ago

Closing in favour of planned new PR