search

elementary / music

Music player and library designed for elementary OS
https://elementary.io
GNU General Public License v3.0
146 stars 49 forks source link

Music's settings button doesn't use standard eOS popover #661

Closed D0J0P closed 2 years ago

D0J0P commented 3 years ago

What Happened

Music's settings button doesn't use the HIG's popover style that every eOS app does, with the pointy end sticking out from the settings button. The animation it has when you click on it is not the same either.

Expected Behavior

That the setting button popover would use elementary's HIG in style and animation.

Steps to Reproduce

  1. Open Music and press the settings button
  2. Open any other app and click it's setting button(other than Photos) or press anything on the wingpanel
  3. Notice the style and animation are different

Logs

Platform Information

Elementary OS 6 Odin

cassidyjames commented 3 years ago

This is just a menu button which is perfectly fine according to the elementary HIG; the reason some other apps use a popover is when they contain more than just menu items. I wouldn't be opposed to moving to a popover here but it's not really necessary.

danirabbit commented 2 years ago

Thanks for your report! We're doing a from-scratch rewrite of Music and this issue no longer applies to the new code base. I'm closing this report since the issue can't be reproduced in the new version of Music.