search

elementary / music

Music player and library designed for elementary OS
https://elementary.io
GNU General Public License v3.0
145 stars 49 forks source link

Use signal to notify when to show error toast #713

Closed treppenwitz03 closed 2 years ago

treppenwitz03 commented 2 years ago

Aims to help with https://github.com/elementary/music/pull/711

@vjr I tried it :)

vjr commented 2 years ago

Thanks for this!

What if I import large number of files and there are many invalid files? Will there be a flood of toasts?

I'll test your branch later today , thanks again!

treppenwitz03 commented 2 years ago

@vjr unfortunately yes at least in this way, they would appear one after another. maybe we can stockpile invalid filenames in an array and show them in one go.

vjr commented 2 years ago

@ZenitsuDev I made a change to only show one toast with the count of invalid files. If this part looks OK to you I can merge to my branch and we can continue working on that single branch for easier review from the devs.

treppenwitz03 commented 2 years ago

@vjr yeah sure! I think just showing the numbers is good