Closed vjr closed 1 year ago
I'm not a huge fan of adding timeouts with magic numbers, but can we at least add a comment that this is a workaround and a link to the upstream issue: https://gitlab.gnome.org/GNOME/gtk/-/issues/4426
The 250 ms timeout could be an issue if there are tens of thousands of tracks (TrackRow
s) each connecting to the current-audio
property notification of the PlaybackManager?
Looks like the upstream has a fix in? If so, this should be re-evaluated.
Yeah this was recently fixed upstream so I'm not sure it's worth carrying this workaround when a platform update will solve it automatically
Oh good to hear it's fixed upstream. Do we want to close this PR right away or wait until the fix actually lands in an update?
Yeah, I feel like we should probably just wait for a platform update with a newer Gtk release and not carry the workaround since it's a pretty minor bug
Fixes in three places: