elementary / notifications

Gtk Notifications Server
https://elementary.io
GNU General Public License v3.0
38 stars 6 forks source link

Revert "Fix #117: Show icons for daemons (#118)" #122

Closed meisenzahl closed 3 years ago

meisenzahl commented 3 years ago

This reverts commit a6d20d5e825900ca37e54c06a4967c8f658ca70b.

Please revert this. We shouldn't be loading desktop files from the autostart folder. This folder is only for desktop files that should be launched with the session (and they don't even need to be fully formed desktop files). Hence why this isn't in the standard lookup path for DesktopAppInfo.

If something (a daemon or otherwise) wants to send notifications, it should install a desktop file to an XDG applications path (e.g. /usr/share/applications). If it should be hidden from the applications menu because it's a daemon, use the NoDisplay key.

Originally posted by @davidmhewitt in https://github.com/elementary/notifications/issues/118#issuecomment-841344688

jeremypw commented 3 years ago

Assigning to David Hewitt as it is pursuant to his request.