Add a badge with set_icon

[danirabbit]

While we don't want apps misrepresenting themselves by removing their own automatically set icon, we can allow them to be more expressive by setting a badge via Notification.set_icon ()

• Added some comments so its more clear how what we get from DBus matches GLib.Notification
• If we get an icon name via the image-path hint, and its not the app icon name, create a badge icon for it

Looks like:

[jgildred]

Hey folks. I just followed the getting started tutorial at https://docs.elementary.io/develop/writing-apps. set_icon appears to be replacing the full icon in the notification instead of showing as an overlay. I expect this is due to the fact that I'm running stable OS 5.1 which does not have this change? If so, then may want to update the tutorial to clarify.

[cassidyjames]

@jgildred ah, yes, exactly. The docs have been updated for elementary OS 6 as it is in the final stages of beta testing and then due to be released. It's a backwards-compatible change since we still show the icon on OS 5.1, but of course the presentation is different as you discovered. We can add a note about that compatibility, at least.

[jgildred]

Sounds good, thanks.

[cassidyjames]

@jgildred the docs have been updated!

[jgildred]

That was quick!

[jgildred]

I noticed add_button also doesn't appear to be working in 5.1. Same issue?

[danirabbit]

@jgildred Yes add_button is only supported in >=6.0. It would be helpful to file new issue reports instead of commenting on a closed pull request so that we can track these issues :)

[jgildred]

Will do. Thanks.

On Jul 7, 2021, at 9:48 AM, Daniel Foré @.***> wrote:

 @jgildred Yes add_button is only supported in >=6.0. It would be helpful to file new issue reports instead of commenting on a closed pull request so that we can track these issues :)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.