search

elementary / notifications

Gtk Notifications Server
https://elementary.io
GNU General Public License v3.0
38 stars 6 forks source link

Notifications coming from web browser playing 2 different sounds in the same time #158

Open milouse opened 2 years ago

milouse commented 2 years ago

Prerequisites

This issue is partly described in this MR https://github.com/elementary/notifications/pull/124#issuecomment-852961862 however it looks like the conversation diverges to supporting only picture?

Describe the bug

Lot of modern web app are able nowadays to generate "desktop notifications" and emitting their own sound. However, each time they do so, it generates both a notification sound from the web browser and the default notification sound of elementary.

I may understand the need of an homogeneous experience. However disabling sound in such webapp seems to also cut the default elementary sound :/

On the second hand, it is very appreciated to be able to differentiate emitting application just by the sound, and if possible I’d prefer keeping the applications sound and just mute the default elementary notification sound.

To Reproduce

  1. Open any Mattermost instance and enable desktop notification with sound
  2. Leave tab open in background and do something else (code, social media…)
  3. Wait for someone to ping you
  4. Mattermost notification pop up, with Mattermost sound and Elementary chime
  5. Go back to Mattermost, leave desktop notification only, without sound
  6. Wait again
  7. This time the notification silently pop up. No sound at all.

You can also reproduce it with google calendar, by setting on/off sound for notifications and wait for next agenda reminder.

Expected behavior

Either one should be able to disable the global notification sound to let all application use the one they want, or at least still emit the default sound when we disable specific sound from inside applications ? My preference goes to the first.

Platform Information

janxkoci commented 1 year ago

How do you "install" webapps? As a browser feature in e.g. Epiphany, or standalone install from appstore like flathub? Which browser do you use?

I've never heard of Mattermost, but I use Slack in Firefox (because I dunno where flatpak Slack downloads files my boss sends me). I can confirm that it makes two sounds when receiving a message. I just realized I could try to disable the elementary sound for Firefox in notifications settings, but Firefox doesn't show up in the list so I cannot do that :confused:

Do your webapps / browsers show up in notifications settings?

milouse commented 1 year ago

I don’t install them. I just run them inside my main web browser (Firefox).

The app list you are speaking about is only for app installed as flatpak, not for "native" app installed from your "native" distribution package manager.

janxkoci commented 1 year ago

I see, and now I noticed you use Arch. I'm not sure elementary devs will spend much time on this, as different webapps will likely use different mechanisms to produce the sounds. Maybe some Firefox extension could help. :shrug:

Funny that I don't see Firefox in the app list, even though I installed it as flatpak (Ubuntu no longer provides deb packages for Firefox & Chromium and instead trick people into installing snaps - ugh :nauseated_face: at least elementary doesn't participate in this nonsense).

Marukesu commented 1 year ago

if the app list talked about is the one in the notifications settings, it list applications that include the X-GNOME-UsesNotifications key with value true in they .desktop file, application that don't include it, or has the value as false follows the "Other" policy.

I may understand the need of an homogeneous experience. However disabling sound in such webapp seems to also cut the default elementary sound :/

this shouldn't be happen. the notification daemon doesn't support or respect any sound hint and i don't see anything that could be making the daemon to not emit sounds in the firefox code.

can you confirm that the "Other" application in the switchboard notification settings has sounds enabled?