Ensure bubbles lose all references when dismissed and destruct.

elementary / notifications

Gtk Notifications Server

https://elementary.io

GNU General Public License v3.0

38 stars 6 forks source link

Ensure bubbles lose all references when dismissed and destruct. #165

Closed jeremypw closed 2 years ago

jeremypw commented 2 years ago

While playing with the demo app, it was noticed that the destructor of bubbles was not being called even though the destroy () function was being called due to a remaining reference. This PR fixes that, although the underlying reason is not entirely clear. Possibly a Vala bug??

tintou commented 2 years ago

It is not a vala bug but this is really not done correctly here anyway, I've opened https://github.com/elementary/notifications/pull/166 as this need to be done Application-wide.

jeremypw commented 2 years ago

Closed in favour of #166.

Thanks @tintou for the better solution.