Application: use startup and dbus_register instead of activate

elementary / notifications

Gtk Notifications Server

https://elementary.io

GNU General Public License v3.0

38 stars 6 forks source link

Closed Marukesu closed 2 years ago

Marukesu commented 2 years ago

set the ApplicationFlags.IS_SERVICE flag so that glib don't try to call activate when running from terminal.
move gtk and canberra configuration to GLib.Application.startup (), and use GLib.Application.application_id and GLib.Application.resource_base_path so we reduce places with an hardcoded app id.
do all the dbus handing on GLib.Application.dbus_register, and only hold when we aquire the org.freedesktop.Notifications name.

Marukesu commented 2 years ago

@jeremypw i think this also supress the error, and are more inline with how GLib.Application/Gtk.Application works.

jeremypw commented 2 years ago

@jeremypw i think this also supress the error, and are more inline with how GLib.Application/Gtk.Application works.

I'll bow to your greater knowledge :smile: