Patch required patched packages for focal

Added lang spec files, but if we really want to do this we should ship them with Code instead of patching: https://github.com/elementary/code/issues/950

network-manager-applet Hide the connection editor desktop, but this only shows up in search, so who cares

software-properties Stop installing unattended upgrades via recommends, but we don't ship this package by default and the long shutdown issue this supposedly causes can't be reproduced

Required patches are now upstream:

desktop-file-utils
epiphany-browser

ibus https://bugs.launchpad.net/ubuntu/+source/ibus/+bug/1835541

system-config-printer Hide the .desktop, but this doesn't appear to show anymore

gnome-settings-daemon

We used to drop an Ubuntu patch that caused a segfault, but it's now gone upstream and the crash is no longer reproducible
DPMS stuff isn't needed anymore since we updated the power plug to handle this correctly

But we need to go through the rest of the list and see if the patches are still required or if we can just use the upstream version.

tintou commented 4 years ago

Most of them are backports which don't need to be built for focal. I'm editing the original issue to show it clearly

danirabbit commented 4 years ago

epiphany shouldn't need any patches anymore since they're carrying everything we need upstream these days

danirabbit commented 3 years ago

Updated this with a lot more info today. There’s a few more packages we don’t need to patch anymore.

I’m really not sure what the BASH patches are intended to do. Is that so we get command names in the tab while it’s running instead of directory names?

davidmhewitt commented 3 years ago

This patch for grub is actually super important: https://github.com/elementary/os-patches/commit/5e7f14b37a82db195cb0f0082b5dfb2e2c69b9e5

It ensures the grub config is correctly updated after kernel updates etc. The reason we need this is caused by the fact we patch base-files to get a different lsb_release. We still want to use Ubuntu's signed bootloader, so we need to map elementary back to Ubuntu.

This is why someone was posting on reddit today about being unable to update their kernel: https://www.reddit.com/r/elementaryos/comments/lhibby/odin_60_preview_cant_update_kernel/

hanaral commented 3 years ago

Shouldn't the mutter drawing bug also be patched?

danirabbit commented 3 years ago

Closing because patches now exist for things listed. New patches should be filed as individual issue reports

elementary / os-patches

Patch required patched packages for focal #91

Packages that we think may need patching (excluding packages mentioned below):

Packages that are backports:

We don't ship/need need the following anymore:

Required patches are now upstream: