elementary / os

The OS build system
https://elementary.io
GNU General Public License v3.0
990 stars 131 forks source link

A bit improvement in build.sh #699

Closed MNR85 closed 8 months ago

MNR85 commented 10 months ago

Hi
I checked build.sh and it is well written, I found 2 improvement.
First we can change BASE_DIR to be REAL directory of build.sh, previous PWD could cause problem if user run script from other directory.
And Second was unnecessary -e flag in echo command. We use -e to escape backslash and here there was no need to use that.
With regards
Milad