Hi
I checked build.sh and it is well written, I found 2 improvement.
First we can change BASE_DIR to be REAL directory of build.sh, previous PWD could cause problem if user run script from other directory.
And Second was unnecessary -e flag in echo command. We use -e to escape backslash and here there was no need to use that.
With regards
Milad
Hi
I checked build.sh and it is well written, I found 2 improvement.
First we can change
BASE_DIR
to be REAL directory of build.sh, previousPWD
could cause problem if user run script from other directory.And Second was unnecessary
-e
flag inecho
command. We use-e
to escape backslash and here there was no need to use that.With regards
Milad