elementary / photos

Photo viewer and organizer designed for elementary OS
https://elementary.io
GNU Lesser General Public License v2.1
105 stars 38 forks source link

Group multiple events for 1 date #628

Closed nielsvl95 closed 2 years ago

nielsvl95 commented 3 years ago

What Happened

All pictures are added in seperate events.

Expected Behavior

Pictures from the same date should be grouped in 1 event

Steps to Reproduce

1.Add photo library

  1. Open folder
  2. Look at multiple events for 1 date

Platform Information

Elementary OS 6.0 Beta 2 Photos app version 2.7.1 Schermafdruk van 2021-07-30 15-16-42

jondale commented 3 years ago

I came here to report this same issue. I installed shotwell to see if it has the same issue and it does not.

jeremypw commented 3 years ago

I think the reason separate events are shown is so you can customise each event name by right clicking on it. I would support, however, another level of (virtual) folder for each day analagous to those already given for each month. I guess it is possible Shotwell added this after elementary forked it. I do not think it would be have been removed by elementary.

marco4mp commented 3 years ago

Hi! @jeremypw. I think it's a bug. Because, separating each photo of the same day into different folders, in my opinion, doesn't make sense.

Example I took 7 photos in August on two different days. 5 photos on Aug.22 and 2 photos on Aug.5.

Shotwell: In August, it shows two folders (two different days) and separates the photos according to the day they were taken.

Captura de pantalla de 2021-10-15 18 08 22

elementary Photos: In August, it shows seven folders. One photo for each folder. 🤔 Captura de pantalla de 2021-10-15 18 08 29

(Excuse my English, I try to do my best 😢)

jeremypw commented 3 years ago

I just discovered there is a way to merge all the events on one day into a single event.

You can split out events from a merged event by selecting them and choosing "New Event" from the context menu.

jeremypw commented 3 years ago

I'll see if I can create a PR that changes the default behaviour so that a single event is created by default for photos on the same day. Or, maybe better, a separate folder per day.

marco4mp commented 3 years ago

Hi @jeremypw. I have new info! I was wondering why this problem did not catch my attention before (elementary 5.1) since I do a lot of work with photos. So I installed Elementary 5.1.7 on a virtual machine to check Photos. And what I thought. Photos on elementary 5.1 have a different behavior, that is, the same as Shotwell.

In both versions I tried the same folder with pictures from three different dates. Captura de pantalla de 2021-11-20 13 01 53

elementary 5.1.7 - Photos 2.7.0

Clicking on the year folder: Photos Hera_Year

Clicking on the month folder: Photos Hera_Month

elementary 6 - Photos 2.7.3

Clicking on the year folder: Photos Odin_Year

Clicking on the month folder: Photos Odin_Month

marco4mp commented 3 years ago

So, the current version of Photos (2.7.3) makes the mistake of using each picture as an event by itself. An "event" should be a kind of "album" containing pictures taken on the same day (like Photos 2.7.0 or Shotwell).

jeremypw commented 3 years ago

Hmm - I'll have to look at where that regression appeared - I assume it was not intentional. If I can revert that regression this PR will not be necessary.

jeremypw commented 3 years ago

The only possible relevant commit I found so far relates to replacing some deprecated code in the way photos were timestamped (unfortunately one of my PRs!) I'll see if that is the culprit.

jeremypw commented 3 years ago

Yeah, that's the culprit. Unfortunately, photos that are already imported will not be affected by simply reverting the change so I will have to find a way to have both the old and new timestamp give the same result.

marco4mp commented 3 years ago

Thanks!