search

elementary / photos

Photo viewer and organizer designed for elementary OS
https://elementary.io
GNU Lesser General Public License v2.1
105 stars 38 forks source link

CheckboardLayout: use rubberband widget path to draw selection band #637

Closed danirabbit closed 3 years ago

danirabbit commented 3 years ago

I'm having some issues here with artifacting on the border. Maybe there's a clear method I'm unaware of? But this makes sure we use actual values for the rubberband element and no hardcoded values

jeremypw commented 3 years ago

It works OK (and is simpler) using rubberband_context.render_background () except there is no frame (unlike the Files selection band). If I add `rubberband_context.render_frame () then I also get the "echo" of the previous frames :disappointed: I'll look into the reason for that.

jeremypw commented 3 years ago

OK, I've fixed the "echo" - needed to increase the area of the rectangle that was being invalidated by 1px on all sides to ensure the frame is erased.

jeremypw commented 3 years ago

@danrabbit Does this look OK to you?