Closed ryonakano closed 2 years ago
If you are going to change the appearance in this PR, then I would lose the long opening instruction which is self-evident from the entry labels.
I would also move the "Remember Password" checkbox close to the Password entry field (in the manner of the Files ConnectServer dialog).
Best wait for UX team input though.
@jeremypw Thank you for your suggestion! I agree with your idea.
Looks like the instruction label is also used for showing error messages (represented in the condition of Mode.FAILED_RETRY_URL
and Mode.FAILED_RETRY_USER
in the AuthenticationPane class), so maybe we can remove the label completely and add a Gtk.InfoBar for these errors, as we do in other places when showing an erro message?
But that would make the PR complicated and this PR don't seem to get interested in for a couple of days from anyone, so I'll separate the design changes in another PR to get this merged easily.
Hmm, looks like the options pane not working, investigating.
OK, now the options pane works fine.
The view still looks bad but again this PR only aims to fix deprecated codes so I'll tweak that in another PR.
BTW I found a demo instance of Piwigo, so we can test the PR using this
Supersedes #674 Review in no whitespace mode
Changes Summary
Replace deprecated Gtk.Table, Gtk.Alignment, Gtk.HButtonBox, Gtk.Widget.reparent, etc. Thus this fixes the following error messages on build:
Steps to test
We can use a demo instance of Piwigo to test the PR.
Before
After