search

elementary / photos

Photo viewer and organizer designed for elementary OS
https://elementary.io
GNU Lesser General Public License v2.1
105 stars 38 forks source link

Copy image #701

Closed jeremypw closed 2 years ago

jeremypw commented 2 years ago

Fixes #53

Replaces #568

This PR extends #568 to copy several different formats onto the clipboard. This allows pasting the requested data type into different apps. Further enhancement includes copying several image files from the CollectionView and adding another option to copy the image metadata as text instead of the uri.

Note that pasting images into Github comments works but only for one file at a time for some reason (pasting multiple files only transfers the first).

Also pasting into Inkscape only works for single images as it is not clear how to store multiple image data into the clipboard.

However pasting multiple files into Files does work.

TheGag96 commented 2 years ago

Hey, thanks for doing this! I've moved on from Elementary but I'm glad to see this feature in there.

jeremypw commented 2 years ago

@zeebok Thanks for looking at this! I need to refresh my memory about the details then I'll try to answer your questions.

jeremypw commented 2 years ago

@zeebok I have answered your query re image/png target inline. Regarding "Copy Metadata" this is to give the option of copying the information about the photo shown in the Info Sidebar into an app that accepts text. If you just copy a photo into such a document then it is the URI to the photo file that is transferred. As to use cases the main one I can think of the top of my head is when reporting bugs about image handling it can be useful to include this information. It might be better put this action into the sidebar itself on reflection but as I was adding actions to the context menu in this PR it was easier to put it there.