elementary / photos

Photo viewer and organizer designed for elementary OS
https://elementary.io
GNU Lesser General Public License v2.1
107 stars 39 forks source link

Use Wallpaper Portal #753

Closed danirabbit closed 2 months ago

danirabbit commented 4 months ago

Problem

We're currently relying on Contractor for setting the wallpaper, but we should be using the Wallpaper Portal

Proposal

Use the Wallpaper Portal: https://valadoc.org/libportal/Xdp.Portal.set_wallpaper.html

Prior Art (Optional)

No response

zeebok commented 2 months ago

It seems like this would involve updating Contractor to not report this action from the call to get_contracts_for_files() or specifically looking for the wallpaper option and replacing it with the libportal version. Given that we really want to see a rewrite maybe the latter option is better to triage this?

danirabbit commented 2 months ago

We're no longer shipping the set wallpaper contract with desktop settings, so this just needs a branch like https://github.com/elementary/files/pull/2432