search

elementary / screenshot

Screenshot tool designed for elementary OS
https://elementary.io
GNU Lesser General Public License v3.0
84 stars 23 forks source link

Replace FileChooserButton for GTK4 #243

Closed treppenwitz03 closed 1 year ago

treppenwitz03 commented 2 years ago

This hopes to check a todo in https://github.com/elementary/screenshot/pull/240 so screenshot can be ported.

jeremypw commented 2 years ago

Maybe should stick to the FileChooserNative API as this is now Flatpak'd?

treppenwitz03 commented 2 years ago

Right! I agree. Thanks @jeremypw

jeremypw commented 2 years ago

Screenshot from 2022-05-31 18 03 40

The drop arrows on the two buttons are of a different size, furthermore the filechooser button does not produce a dropdown when clicked, but a dialog so I think it should have an ellipsis?

jeremypw commented 2 years ago

Screenshot from 2022-05-31 18 44 31

This is how it looks after applying my suggestions (I also increased the icon size to 24px but that is not essential).

treppenwitz03 commented 2 years ago

@jeremypw is there an icon we can use for ellipsis? Thank you.

treppenwitz03 commented 2 years ago

oh I found it! it is content-loading-symbolic

treppenwitz03 commented 2 years ago

Screenshot from 2022-06-01 04 30 48

it does not seem aligned still.

jeremypw commented 2 years ago

Probably best seek @danrabbit 's opinion on the finer points of the design.

jeremypw commented 1 year ago

Still being held up by the existence of #253.