search

elementary / settings-daemon

GNU General Public License v3.0
14 stars 11 forks source link

Settings portal doesn't work with automatic accent color #149

Open alice-mkh opened 1 week ago

alice-mkh commented 1 week ago

What Happened?

Basically if set to automatic we just return black color instead, which is not that great.

Steps to Reproduce

  1. Set accent to automatic
  2. Open any non-elementary app that supports fdo accent color (e.g. nightly gnome apps)

Expected Behavior

It should just follow the same color elementary apps use

OS Version

7.x (Horus)

Software Version

Compiled from git

Log Output

No response

Hardware Info

No response

alice-mkh commented 1 week ago

There is relevant code for that in AccentColorManager, but the problem is that the portal is a separate binary atm. They can be merged, but it's messy.

A simpler (tho less robust) way is to have portal listen to gtk-theme instead and check the name. I can open a MR, but wanted to make sure it's fine here.