search

elementary / sideload

Sideload Flatpaks on elementary OS
https://elementary.io
GNU General Public License v3.0
46 stars 14 forks source link

Consider subclassing Granite.MessageDialog #111

Closed pongloongyeat closed 3 years ago

pongloongyeat commented 3 years ago

Problem

Since AbstractView essentially looks like a Granite.MessageDialog, consider subclassing Granite.MessageDialog instead of a custom AbstractView so that design changes to Granite.MessageDialog is reflected in Sideload.

Proposal

Subclass Granite.MessageDialog

hanaral commented 3 years ago

I'm not sure if MessageDialog is supposed to be used by itself; I think it was @jeremypw who said that to me a while back(?)

danirabbit commented 3 years ago

Since Sideload has a multi-page design, Granite.MessageDialog doesn't really work here