search

elementary / sideload

Sideload Flatpaks on elementary OS
https://elementary.io
GNU General Public License v3.0
46 stars 14 forks source link

Support dark style preference #95

Closed danirabbit closed 4 years ago

danirabbit commented 4 years ago

Fixes #94

4jNsY6fCVqZv commented 4 years ago

Besides, does this solution also work for third-party apps?

cassidyjames commented 4 years ago

@4jNsY6fCVqZv yes, it is just using the Granite utility. We will likely write documentation on how third-party apps can support a dark style preference once we're closer to the release.

4jNsY6fCVqZv commented 4 years ago

@cassidyjames Thanks for documenting this! If I want to implement these changes into the code of a third-party app right now, do I need a separate development branch because otherwise an app version that depends on Granite >=5.4.0 will probably not run on Hera systems anymore?

cassidyjames commented 4 years ago

@4jNsY6fCVqZv I believe we released that granite update to Hera, and if an app does this on Hera, it will silently fail and continue to work as before. For example, WingPanel and Switchboard have this code in Hera as well.

4jNsY6fCVqZv commented 4 years ago

@cassidyjames Thanks again!