search

elementary / stylesheet

The GTK Stylesheet for elementary OS
https://elementary.io
GNU General Public License v3.0
320 stars 74 forks source link

Meson: rebuild without requiring ninja clean #1202

Open danirabbit opened 2 years ago

danirabbit commented 2 years ago

What Happened?

The stylesheet doesn't get properly rebuilt if you build with just ninja and not ninja clean.

Steps to Reproduce

  1. Build with ninja
  2. Make changes and build again with ninja
  3. Test and see that changes weren't built

Expected Behavior

The build system should be set up such that it produces new builds reflecting the latest source code changes when building with ninja and not requiring ninja clean

OS Version

7.x (Early Access)

Software Version

Compiled from git

Log Output

No response

Hardware Info

No response

eli-schwartz commented 2 years ago

Meson only knows about the primary input file, which just loads other files. In order to do proper incremental updates, you will need depfile support (the same minimal, Make-compatible output: input1 input2 input3 format emitted by GCC's -MD flag); it seems sassc is in deep maintenance mode so it's not clear that such support will ever land upstream.

(No, dart-sass doesn't support this either.)

eli-schwartz commented 2 years ago

Hmm, turns out there is indeed a PR sort of like this (my original google-fu didn't find it due to it not having the right keywords).

https://github.com/sass/sassc/pull/228

BAProductions commented 1 year ago

When I build the theme in a VM the changes do take effect

BAProductions commented 1 year ago

Mabe eOS could add Compiling support to the code app