search

elementary / stylesheet

The GTK Stylesheet for elementary OS
https://elementary.io
GNU General Public License v3.0
321 stars 74 forks source link

GTK4: Support `.keyboard-activating` class for buttons #1246

Closed lenemter closed 1 year ago

lenemter commented 1 year ago

See https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/3390

I guess this class needs to be used in some other places, but this is bare minimum for https://github.com/elementary/calculator/pull/242

BAProductions commented 1 year ago

See https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/3390

I guess this class needs to be used in some other places, but this is bare minimum for elementary/calculator#242

We need to see if other UI Elements use .keyboard-activating as well & add it to the theme as needed.

alice-mkh commented 1 year ago

No, it's a GtkButton thing.

lenemter commented 1 year ago

Seems like more work needed to make this work with different styles. Converting to draft until issues resolved.

lenemter commented 1 year ago

Seems like more work needed to make this work with different styles. Converting to draft until issues resolved.

The issue is in https://github.com/elementary/calculator/pull/242.

Ready for review.

BAProductions commented 1 year ago

This also apply to GTK3

alice-mkh commented 1 year ago

No, it doesn't. GTK3 just uses the :active state for that.