elementary / stylesheet

The GTK Stylesheet for elementary OS
https://elementary.io
GNU General Public License v3.0
321 stars 74 forks source link

Window margins cause titlebar issues in Mutter 44 #1253

Closed davidmhewitt closed 1 year ago

davidmhewitt commented 1 year ago

In Mutter 44, X11 SSD titlebars run as a separate GTK 4 process. With our stylesheet, they look like this:

image

This is due to this margin in the stylesheet:

https://github.com/elementary/stylesheet/blob/0c841189a3ae0b06b7f5cf551d3d2c6266eda80e/src/gtk-4.0/widgets/_windows.scss#L8

If we remove this margin, it looks like this:

image

Can we have a bit of an investigation into why we have a margin here when Adwaita doesn't, and whether it's needed with a view to removing it in the next release?

alice-mkh commented 1 year ago

That margin looks like it’s a gtk3-ism, since iirc 3 was using it to determine the invisible border size, while 4 doesn’t.

You also want to disable round corners for ssd windows, you can see the bottom corners are glitchy on that terminal.

danirabbit commented 1 year ago

Yup that's exactly it. It was a quirk to set the resize area. I'll do a branch :)