Windows: Remove Gtk3-isms and fix Mutter 44

[danirabbit]

Fixes #1253

[davidmhewitt]

Mutter 44 screenshot with this branch:

[danirabbit]

@davidmhewitt I'm sure I'll have to do something more invasive to fix those headerbar box shadows etc, but does the latest commit fix the border at least?

[alice-mkh]

Not sure what's up with the padding around header bar...

One thing is I don't know if adwaita currently works well for Mutter - it's not using libadwaita, and I don't think it has any special case for ssd border radius either, so... yay I guess?

[davidmhewitt]

Nope :confused:

Adwaita comparison:

[davidmhewitt]

And now for some CSS property comparisons, or at least the most relevant looking ones I could fit into screenshots from my VM:

Toplevel `mutter-x11-frames` window node (Adwaita):


Toplevel `mutter-x11-frames` window node (elementary):


`mutter-x11-frames` `MetaFrameContent` node (Adwaita):


`mutter-x11-frames` `MetaFrameContent` node (elementary):


`mutter-x11-frames` `MetaFrameHeader` node (Adwaita):


`mutter-x11-frames` `MetaFrameHeader` node (elementary):


`mutter-x11-frames` headerbar node (Adwaita):


`mutter-x11-frames` headerbar node (elementary):


[alice-mkh]

Well, that’s not Adwaita. That’s Default.

Edit: i.e. what I mean is that chances are it's broken in Adwaita too and was copied here. Not sure tho, I never tested that combination (and it was impossible to test until way after that style was last touched, anyway)

[davidmhewitt]

Well, that’s not Adwaita. That’s Default. Edit: i.e. what I mean is that chances are it's broken in Adwaita too and was copied here. Not sure tho, I never tested that combination (and it was impossible to test until way after that style was last touched, anyway)

Hm, for some reason, it doesn't seem to be possible to select Adwaita as a stylesheet in the inspector when you're running it against mutter-x11-frames.

Tbh, I don't even know what the difference between Default and Adwaita are.

[alice-mkh]

Adwaita is a part of libadwaita. The difference:

Given

Stolen from Adwaita

I'm assuming it was based on the latter.

[alice-mkh]

Any reason to style .titlebar at all? I mean if it's not a header bar, it shouldn't be styled like a header bar then. And if it is, it's already a header bar and there won't be anything nested in there.

[danirabbit]

@Exalm there are some apps that use a box.titlebar with a windowcontrols child because they're inside a paned instead of using a headerbar

[alice-mkh]

Mm, I mean if you want to support that - ok I guess.

[danirabbit]

Yeah it looks like they're just gonna have to eat shit and do something else since there's no other way to get around the padding issue for apps that nest a headerbar inside a .titlebar

[alice-mkh]

In libadwaita we have a variant of header bar where start/end buttons can be hidden independently instead, and in the new widgets that header bar manages buttons automatically.

You could do something similar, so that dual paned apps can just use header bars instead of boxes :)