search

elementary / stylesheet

The GTK Stylesheet for elementary OS
https://elementary.io
GNU General Public License v3.0
321 stars 74 forks source link

Buttons don't play well with text scaling. #1294

Closed tnetenbaa closed 3 months ago

tnetenbaa commented 3 months ago

What Happened?

When scaling text below 1.00 in settings, everything but buttons with text seem to scale appropriately. For example, I have scaling set to 0.80, and the buttons have a huge gap below the text. Screenshot from 2024-05-26 04 39 38

Steps to Reproduce

Open something that has a multi-choice dialog (ex. "Run as Administrator" with Files)

Expected Behavior

Buttons scale correctly.

OS Version

7.x (Horus)

Software Version

Latest release (I have run all updates)

Log Output

No response

Hardware Info

No response

danirabbit commented 3 months ago

Looks like this was an issue with Gtk.ButtonBox which no longer exists in GTK 4:

Screenshot from 2024-05-27 08 22 56

Closing as "Out of scope" since it's with a removed upstream component and anything migrated to GTK 4 won't experience this issue

tnetenbaa commented 3 months ago

Is there any ETA on when this fix will hit Files? Even in the latest daily for OS 8, the issue is still present. Screenshot from 2024-05-27 17 28 07

danirabbit commented 3 months ago

@tnetenbaa there's some work in progress to port files to GTK 4, but I can't say it looks like it will be finished imminently. There's no way to give an estimation on how long it will take. It just depends on time available from contributors