search

elementary / switchboard-plug-about

Switchboard System Plug
GNU General Public License v3.0
25 stars 17 forks source link

Spelling: -firmware updates #220

Closed comradekingu closed 2 years ago

comradekingu commented 3 years ago

Upgrades aren't updates, and upgrading firmware even less so.

cassidyjames commented 2 years ago

This PR makes a ton of string changes that all are individually contested, and now conflicts with master. I'm going to close this, but feel free to open smaller PRs that change fewer strings so those can be evaluated and potentially approved on their own.

comradekingu commented 2 years ago

@cassidyjames It has to be a consistent approach, or it is worthless. This is neither professional or consistent in its own right, and it breaks with conventions used elsewhere in elementary OS. I can detail some errors made and the confusion that arises, from an electronics background, in translation, or support point of view.

You both failed to see it, and that means users suffer. There is just one contested string, and on the basis of "It doesn't seem to clarify anything …" you will sadly be proven wrong. "It's not within the scope of this UI to tell people to sideload their own firmware" misses the point. Vendors will have all sorts of other schemes to upgrade firmware, and that is safety-critical. Nobody is being told how, but rather made aware.

comradekingu commented 2 years ago

@danrabbit

I think some of these sound a bit less natural or maybe less like US English. I've left a few inline comments

I detailed the problems found, which mostly explains my choices. In my head there is no possible way a concern for what sounds more American could be paramount. Even so, can we work within the realms of gains made?

With all the work going into other stuff, installing firmware is not where it should all come apart.