search

elementary / switchboard-plug-about

Switchboard System Plug
GNU General Public License v3.0
25 stars 18 forks source link

GETTEXT_PACKAGE value typo #225

Closed bobby285271 closed 3 years ago

bobby285271 commented 3 years ago

https://github.com/elementary/switchboard-plug-about/blob/56152af46647de006207d851f62922a5d9983e22/src/meson.build#L17

Will be great to change this to config_data.set('GETTEXT_PACKAGE', meson.project_name() + '-plug'), we were reusing this line of code downsteam due to our specific localdir path in NixOS and were surprised to see that translations are not applied because of this (see https://github.com/NixOS/nixpkgs/pull/130380/commits/9f76913a141913a42359159854df7d779d244e47) .

Reference: https://github.com/NixOS/nixpkgs/pull/130380#discussion_r685142804

https://github.com/elementary/switchboard-plug-about/blob/56152af46647de006207d851f62922a5d9983e22/meson.build#L7

Thanks for reading this :-)

bobby285271 commented 3 years ago

Resolved in #229.