search

elementary / switchboard-plug-about

Switchboard System Plug
GNU General Public License v3.0
25 stars 17 forks source link

Wallpaper placeholder is visible behind elementary logo during navigation to plug #272

Closed jlnr closed 6 months ago

jlnr commented 12 months ago

What Happened?

When first opening this plug, the logo changes while the page is being animated in.

After the animation finishes, there is a faint inner "e" inside the outer "e". I don't think this is intentional?

https://github.com/elementary/switchboard-plug-about/assets/70772/578a24f5-2369-4a9f-bf5a-e282fb065c8c

Steps to Reproduce

  1. Open Switchboard
  2. Open "About" plug

Expected Behavior

The logo being shown is always the right one.

OS Version

7.x (Horus)

Software Version

Latest release (I have run all updates)

Log Output

No response

Hardware Info

This is in a live session from the 2023-09-07 Daily ISO on a MacBook Pro.

danirabbit commented 12 months ago

Yeah because you're on daily the wallpaper being used here is the daily wallpaper which has a logo in it. So that's to be expected

jlnr commented 12 months ago

I took another look at the video and the code, and adjusted the issue title accordingly. The double "e" looks a bit odd but is correct. However, the other placeholder (somewhere around 0:01.000 in the video) should probably not be visible.

Maybe there's a way to only fade in the image view once it has finished loading. Edit: Actually it looks like it's trying to cross-fade for a couple of frames, but in person it just looked like an immediate replacement.

danirabbit commented 8 months ago

I can't reproduce this in the GTK 4 port. @jlnr can you still reproduce this with the latest from main? Note that you'll need to run io.elementary.settings and not io.elementary.switchboard

jlnr commented 6 months ago

Oof, sorry, I totally missed this GitHub notification. =( Thanks for looking into it and @leolost2605 for the fix 🙏